Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

rpc: fix ExpandHome restrictions bypass #667

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Oct 13, 2021

Closes: KS-THA-F-05

Description

go-home seems to be using environment variables first


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Can you add a changelog entry and fix the lint issues?

rpc/ethereum/namespaces/debug/utils.go Outdated Show resolved Hide resolved
`go-home` seems to be using environment variables first
@fedekunze fedekunze enabled auto-merge (squash) October 13, 2021 09:25
@fedekunze fedekunze merged commit 8e12d94 into evmos:main Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants